netdev - Re: [PATCH net v3] net: lan966x: fix parameter check in two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 14 Jul 2023 11:12:01 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Minjie Du <duminjie@...o.com>, opensource.kernel@...o.com,
 netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
 UNGLinuxDriver@...rochip.com, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Richard Cochran <richardcochran@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Wang Ming <machel@...o.com>
Subject: Re: [PATCH net v3] net: lan966x: fix parameter check in two functions

> Make IS_ERR_OR_NULL() judge the vcap_get_rule() function return.
> in lan966x_ptp_add_trap() and lan966x_ptp_del_trap().

Will interests grow for another improved change description?

…
> ---
> V2 -> V3: set the target tree in the subject and add 'Reviewed-by:' tag.
> V1 -> V2: add Fixes tag.
> V1: fix parameter check in two functions.
> ---
>  drivers/net/ethernet/microchip/lan966x/lan966x_ptp.c | 4 ++--
…

I suggest once more to replace the second marker by a line break.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n711

Would a subject like “[PATCH net v4] net: lan966x: Fix an error check in two functions”
be more appropriate?

Regards,
Markus