netdev - Re: [PATCH net] ipv6 addrconf: fix bug where deleting a mngtmpaddr can create a new temporary address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jul 2023 17:18:40 -0600
From: David Ahern <dsahern@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, Jiri Pirko <jiri@...nulli.us>
Cc: Maciej Żenczykowski <maze@...gle.com>,
 Linux Network Development Mailing List <netdev@...r.kernel.org>,
 "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] ipv6 addrconf: fix bug where deleting a mngtmpaddr
 can create a new temporary address

On 7/18/23 5:08 PM, Jakub Kicinski wrote:
> On Fri, 14 Jul 2023 08:49:55 -0600 David Ahern wrote:
>>> I did consider that and I couldn't quite convince myself that simply
>>> removing "|| list_empty()" from the if statement is necessarily correct
>>> (thus I went with the more obviously correct change).
>>>
>>> Are you convinced dropping the || list_empty would work?
>>> I assume it's there for some reason...  
>>
>> I am hoping Jiri can recall why that part was added since it has the
>> side effect of adding an address on a delete which should not happen.
> 
> Did we get stuck here? Jiri are you around to answer?

If Jiri is not around or does not remember, I suggest moving forward by
dropping the list_empty check. Adding an address when one is deleted is
not intuitive at all.