netdev - Re: [PATCH net] ipv6: do not match device when remove source route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 19 Jul 2023 15:56:52 +0800
From: Hangbin Liu <liuhangbin@...il.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Thomas Haller <thaller@...hat.com>
Subject: Re: [PATCH net] ipv6: do not match device when remove source route

On Wed, Jul 19, 2023 at 03:21:48PM +0800, Hangbin Liu wrote:
> On Tue, Jul 18, 2023 at 02:42:02PM +0300, Ido Schimmel wrote:
> > > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > > index 64e873f5895f..ab8c364e323c 100644
> > > --- a/net/ipv6/route.c
> > > +++ b/net/ipv6/route.c
> > > @@ -4607,7 +4607,6 @@ void rt6_remove_prefsrc(struct inet6_ifaddr *ifp)
> > >  {
> > >  	struct net *net = dev_net(ifp->idev->dev);
> > >  	struct arg_dev_net_ip adni = {
> > > -		.dev = ifp->idev->dev,
> > 
> > Wouldn't this affect routes in different VRFs?
> > 
> > See commit 5a56a0b3a45d ("net: Don't delete routes in different VRFs")
> > and related fixes:
> 
> Thanks for this notify. I saw this is for IPv4 only and there is no IPv6 version.
> I can try add an IPv6 version patch for this issue. The fib_tb_id is based
> on table id. So in same table we still need to not check the device and remove
> all source routes.

Oh, I saw struct fib6_info has fib6_table, I think we can check this when
remove prefsrc.

Thanks
Hangbin