netdev - Re: [PATCH net-next 2/4] eth: stmmac: let page recycling happen with skbs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 20 Jul 2023 20:02:18 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>, <davem@...emloft.net>
CC: <netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<peppe.cavallaro@...com>, <alexandre.torgue@...s.st.com>,
	<joabreu@...opsys.com>, <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH net-next 2/4] eth: stmmac: let page recycling happen with
 skbs

On 2023/7/20 9:04, Jakub Kicinski wrote:
> stmmac removes pages from the page pool after attaching them
> to skbs. Use page recycling instead.
> 
> skb heads are always copied, and pages are always from page
> pool in this driver. We could as well mark all allocated skbs
> for recycling.

LGTM,
Reviewed-by: Yunsheng Lin <linyunsheng@...wei.com>