netdev - Re: MediaTek Frame Engine Ethernet: does it need any resets?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 29 Jul 2023 16:58:10 +0300
From: Arınç ÜNAL <arinc.unal@...nc9.com>
To: Rafał Miłecki <zajec5@...il.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: Network Development <netdev@...r.kernel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 linux-mips@...r.kernel.org,
 linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
 linux-mediatek <linux-mediatek@...ts.infradead.org>,
 Sergio Paracuellos <sergio.paracuellos@...il.com>,
 Daniel Golle <daniel@...rotopia.org>
Subject: Re: MediaTek Frame Engine Ethernet: does it need any resets?

On 29.07.2023 14:45, Rafał Miłecki wrote:
> Hi,
> 
> I'm trying to understand MediaTek's Ethernet controller resets.
> 
> I noticed there is sth fishy when checking dts files. See following
> errors:
> 
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
> ethernet@...00000: resets: [[2, 6], [2, 23]] is too short
>          From schema: 
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
> ethernet@...00000: reset-names:1: 'gmac' was expected
>          From schema: 
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
> ethernet@...00000: reset-names: ['fe', 'eth'] is too short
>          From schema: 
> Documentation/devicetree/bindings/net/mediatek,net.yaml
> arch/mips/boot/dts/ralink/mt7621-tplink-hc220-g5-v1.dtb: 
> ethernet@...00000: Unevaluated properties are not allowed 
> ('reset-names', 'resets' were unexpected)
>          From schema: 
> Documentation/devicetree/bindings/net/mediatek,net.yaml

Sigh, looks like this patch was applied regardless of my points here. 
Now we're here picking up the pieces.

https://lore.kernel.org/netdev/b6c7462d-99fc-a8e1-1cc2-d0a1efc7c34d@arinc9.com/

> 
> 
> 1. Binding mediatek,net.yaml
> It says that when present, there must be 3 resets: fe, gmac, ppe
> 
> 2. mt7621.dtsi
> It specifies 2 resets: fe, eth
> 
> 3. mt7622.dtsi
> It doesn't specify any resets
> 
> 4. mt7629.dtsi
> It doesn't specify any resets
> 
> 5. drivers/net/ethernet/mediatek/
> I don't see any reset_control_* code at all
> 
> 
> Can someone help me what's the actual case with resets? Are they needed?
> Are they used?

I'm adding Sergio to CC as they've been the one working on this on 
mt7621.dtsi.

There's relevant information here.

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=64b2d6ffff862c0e7278198b4229e42e1abb3bb1

Arınç