netdev - [PATCH -next 5/6] net: fjes: Remove an unnecessary ternary operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 4 Aug 2023 11:53:45 +0800
From: Ruan Jinjie <ruanjinjie@...wei.com>
To: <sgoutham@...vell.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <jesse.brandeburg@...el.com>,
	<anthony.l.nguyen@...el.com>, <tariqt@...dia.com>, <s.shtylyov@....ru>,
	<aspriel@...il.com>, <franky.lin@...adcom.com>,
	<hante.meuleman@...adcom.com>, <kvalo@...nel.org>,
	<richardcochran@...il.com>, <yoshihiro.shimoda.uh@...esas.com>,
	<ruanjinjie@...wei.com>, <u.kleine-koenig@...gutronix.de>,
	<mkl@...gutronix.de>, <lee@...nel.org>, <set_pte_at@...look.com>,
	<linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, <linux-rdma@...r.kernel.org>,
	<linux-renesas-soc@...r.kernel.org>, <linux-wireless@...r.kernel.org>,
	<brcm80211-dev-list.pdl@...adcom.com>, <SHA-cyfmac-dev-list@...ineon.com>
Subject: [PATCH -next 5/6] net: fjes: Remove an unnecessary ternary operator

There is a ternary operator, the true or false judgement of which
is unnecessary in C language semantics.

Signed-off-by: Ruan Jinjie <ruanjinjie@...wei.com>
---
 drivers/net/fjes/fjes_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/fjes/fjes_main.c b/drivers/net/fjes/fjes_main.c
index 2513be6d4e11..a0d915d1dbed 100644
--- a/drivers/net/fjes/fjes_main.c
+++ b/drivers/net/fjes/fjes_main.c
@@ -612,7 +612,7 @@ fjes_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
 	eth = (struct ethhdr *)skb->data;
 	my_epid = hw->my_epid;
 
-	vlan = (vlan_get_tag(skb, &vlan_id) == 0) ? true : false;
+	vlan = vlan_get_tag(skb, &vlan_id) == 0;
 
 	data = skb->data;
 	len = skb->len;
-- 
2.34.1