netdev - Re: [PATCH net] selftests: bonding: do not set port down before adding to bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 22 Aug 2023 02:10:21 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Hangbin Liu <liuhangbin@...il.com>
Cc: netdev@...r.kernel.org, j.vosburgh@...il.com, davem@...emloft.net,
 kuba@...nel.org, pabeni@...hat.com, edumazet@...gle.com, liali@...hat.com,
 jiri@...dia.com, razor@...ckwall.org, phil@....cc, shaozhengchao@...wei.com
Subject: Re: [PATCH net] selftests: bonding: do not set port down before adding to
 bond

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Thu, 17 Aug 2023 16:24:59 +0800 you wrote:
> Before adding a port to bond, it need to be set down first. In the
> lacpdu test the author set the port down specifically. But commit
> a4abfa627c38 ("net: rtnetlink: Enslave device before bringing it up")
> changed the operation order, the kernel will set the port down _after_
> adding to bond. So all the ports will be down at last and the test failed.
> 
> In fact, the veth interfaces are already inactive when added. This
> means there's no need to set them down again before adding to the bond.
> Let's just remove the link down operation.
> 
> [...]

Here is the summary with links:
  - [net] selftests: bonding: do not set port down before adding to bond
    https://git.kernel.org/netdev/net/c/be809424659c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html