netdev - Re: [PATCH 6/12] wifi: mac80211: Do not include crypto/algapi.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 24 Aug 2023 08:59:08 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, Eric Biggers
 <ebiggers@...nel.org>, "Theodore Y.Ts'o" <tytso@....edu>, Jaegeuk Kim
 <jaegeuk@...nel.org>, linux-fscrypt@...r.kernel.org, Richard Weinberger
 <richard@....at>, linux-mtd@...ts.infradead.org, Marcel Holtmann
 <marcel@...tmann.org>, Johan Hedberg <johan.hedberg@...il.com>, Luiz
 Augusto von Dentz <luiz.dentz@...il.com>, linux-bluetooth@...r.kernel.org,
 Ilya Dryomov <idryomov@...il.com>,  Xiubo Li <xiubli@...hat.com>, Jeff
 Layton <jlayton@...nel.org>, ceph-devel@...r.kernel.org,  Steffen Klassert
 <steffen.klassert@...unet.com>, "David S. Miller" <davem@...emloft.net>,
 netdev@...r.kernel.org,  linux-wireless@...r.kernel.org, Matthieu Baerts
 <matthieu.baerts@...sares.net>,  Mat Martineau <martineau@...nel.org>,
 Chuck Lever <chuck.lever@...cle.com>, Neil Brown <neilb@...e.de>, 
 linux-nfs@...r.kernel.org, Mimi Zohar <zohar@...ux.ibm.com>, 
 linux-integrity@...r.kernel.org, "Jason A.Donenfeld" <Jason@...c4.com>,
 Ayush Sawal <ayush.sawal@...lsio.com>
Subject: Re: [PATCH 6/12] wifi: mac80211: Do not include crypto/algapi.h

On Thu, 2023-08-24 at 13:10 +0800, Herbert Xu wrote:
> On Wed, Aug 23, 2023 at 12:34:35PM +0200, Johannes Berg wrote:
> > 
> > No objection, of course, but I don't think it's necessarily clear that
> > it "is for internal use only", it literally says:
> > 
> >  * Cryptographic API for algorithms (i.e., low-level API).
> > 
> > which really isn't the same as "don't use this file".
> > 
> > Might want to clarify that, or even move it into crypto/ from
> > include/crypto/ or something?
> 
> Yes it should be in include/crypto/internal.  Once the churn gets
> small enough I'll move it there.
> 

Sounds good :)

I was kind of waiting to see - but now that others have applied some
patches to their tree I've done the same.

johannes