netdev - Re: [PATCH net v4] docs: netdev: document patchwork patch states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 4 Sep 2023 11:50:51 +0100
From: Martin Habets <habetsm.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com, corbet@....net, workflows@...r.kernel.org,
	linux-doc@...r.kernel.org, rdunlap@...radead.org,
	laurent.pinchart@...asonboard.com, sd@...asysnail.net
Subject: Re: [PATCH net v4] docs: netdev: document patchwork patch states

On Fri, Sep 01, 2023 at 07:24:05AM -0700, Jakub Kicinski wrote:
> The patchwork states are largely self-explanatory but small
> ambiguities may still come up. Document how we interpret
> the states in networking.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Martin Habets <habetsm.xilinx@...il.com>

> ---
> v4:
>  - clarify that patches once set to Awaiting Upstream will stay there
> v3: no change
> v2: https://lore.kernel.org/all/20230830220659.170911-1-kuba@kernel.org/
>  - add a sentence about New vs Under Review
>  - s/maintainer/export/ for Needs ACK
>  - fix indent
> v1: https://lore.kernel.org/all/20230828184447.2142383-1-kuba@kernel.org/
> 
> CC: corbet@....net
> CC: workflows@...r.kernel.org
> CC: linux-doc@...r.kernel.org
> 
> CC: rdunlap@...radead.org
> CC: laurent.pinchart@...asonboard.com
> CC: sd@...asysnail.net
> ---
>  Documentation/process/maintainer-netdev.rst | 32 ++++++++++++++++++++-
>  1 file changed, 31 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/process/maintainer-netdev.rst b/Documentation/process/maintainer-netdev.rst
> index c1c732e9748b..db1b81cfba9b 100644
> --- a/Documentation/process/maintainer-netdev.rst
> +++ b/Documentation/process/maintainer-netdev.rst
> @@ -120,7 +120,37 @@ Status of a patch can be checked by looking at the main patchwork
>    https://patchwork.kernel.org/project/netdevbpf/list/
>  
>  The "State" field will tell you exactly where things are at with your
> -patch. Patches are indexed by the ``Message-ID`` header of the emails
> +patch:
> +
> +================== =============================================================
> +Patch state        Description
> +================== =============================================================
> +New, Under review  pending review, patch is in the maintainer’s queue for
> +                   review; the two states are used interchangeably (depending on
> +                   the exact co-maintainer handling patchwork at the time)
> +Accepted           patch was applied to the appropriate networking tree, this is
> +                   usually set automatically by the pw-bot
> +Needs ACK          waiting for an ack from an area expert or testing
> +Changes requested  patch has not passed the review, new revision is expected
> +                   with appropriate code and commit message changes
> +Rejected           patch has been rejected and new revision is not expected
> +Not applicable     patch is expected to be applied outside of the networking
> +                   subsystem
> +Awaiting upstream  patch should be reviewed and handled by appropriate
> +                   sub-maintainer, who will send it on to the networking trees;
> +                   patches set to ``Awaiting upstream`` in netdev's patchwork
> +                   will usually remain in this state, whether the sub-maintainer
> +                   requested changes, accepted or rejected the patch
> +Deferred           patch needs to be reposted later, usually due to dependency
> +                   or because it was posted for a closed tree
> +Superseded         new version of the patch was posted, usually set by the
> +                   pw-bot
> +RFC                not to be applied, usually not in maintainer’s review queue,
> +                   pw-bot can automatically set patches to this state based
> +                   on subject tags
> +================== =============================================================
> +
> +Patches are indexed by the ``Message-ID`` header of the emails
>  which carried them so if you have trouble finding your patch append
>  the value of ``Message-ID`` to the URL above.
>  
> -- 
> 2.41.0
>