netdev - RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index corruption.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 8 Sep 2023 02:51:13 +0000
From: Ratheesh Kannoth <rkannoth@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sunil Kovvuri
 Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam
	<hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org"
	<kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "hawk@...nel.org"
	<hawk@...nel.org>,
        "alexander.duyck@...il.com" <alexander.duyck@...il.com>,
        "ilias.apalodimas@...aro.org" <ilias.apalodimas@...aro.org>,
        "linyunsheng@...wei.com" <linyunsheng@...wei.com>,
        "bigeasy@...utronix.de"
	<bigeasy@...utronix.de>
Subject: RE: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index
 corruption.

> From: Simon Horman <horms@...nel.org>
> Subject: [EXT] Re: [PATCH net v2] octeontx2-pf: Fix page pool cache index
> corruption.
> -void cn10k_refill_pool_ptrs(void *dev, struct otx2_cq_queue *cq)
> > +int cn10k_refill_pool_ptrs(void *dev, struct otx2_cq_queue *cq)
> >  {
> >  	struct otx2_nic *pfvf = dev;
> >  	u64 ptrs[NPA_MAX_BURST];
> >  	int num_ptrs = 1;
> >  	dma_addr_t bufptr;
> > +	int cnt = cq->pool_ptrs;
> 
> nit: please arrange local variables in new Networking code in reverse xmas
>      tree order - longest line to shortest.
ACK

-Ratheesh