netdev - Re: [PATCH net-next 00/14] ipv6: round of data-races fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 14 Sep 2023 12:25:49 +0200
From: Simon Horman <horms@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
	eric.dumazet@...il.com
Subject: Re: [PATCH net-next 00/14] ipv6: round of data-races fixes

On Tue, Sep 12, 2023 at 04:01:58PM +0000, Eric Dumazet wrote:
> This series is inspired by one related syzbot report.
> 
> Many inet6_sk(sk) fields reads or writes are racy.
> 
> Move 1-bit fields to inet->inet_flags to provide
> atomic safety. inet6_{test|set|clear|assign}_bit() helpers
> could be changed later if we need to make room in inet_flags.
> 
> Also add missing READ_ONCE()/WRITE_ONCE() when
> lockless readers need access to specific fields.
> 
> np->srcprefs will be handled separately to avoid merge conflicts
> because a prior patch was posted for net tree.
> 
> Eric Dumazet (14):
>   ipv6: lockless IPV6_UNICAST_HOPS implementation
>   ipv6: lockless IPV6_MULTICAST_LOOP implementation
>   ipv6: lockless IPV6_MULTICAST_HOPS implementation
>   ipv6: lockless IPV6_MTU implementation
>   ipv6: lockless IPV6_MINHOPCOUNT implementation
>   ipv6: lockless IPV6_RECVERR_RFC4884 implementation
>   ipv6: lockless IPV6_MULTICAST_ALL implementation
>   ipv6: lockless IPV6_AUTOFLOWLABEL implementation
>   ipv6: lockless IPV6_DONTFRAG implementation
>   ipv6: lockless IPV6_RECVERR implemetation
>   ipv6: move np->repflow to atomic flags
>   ipv6: lockless IPV6_ROUTER_ALERT_ISOLATE implementation
>   ipv6: lockless IPV6_MTU_DISCOVER implementation
>   ipv6: lockless IPV6_FLOWINFO_SEND implementation

For series,

Reviewed-by: Simon Horman <horms@...nel.org>