netdev - RE: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request immediately after add/delete vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 15 Sep 2023 08:40:11 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, poros
	<poros@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC: ivecera <ivecera@...hat.com>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"horms@...nel.org" <horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "davem@...emloft.net"
	<davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
 immediately after add/delete vlan

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Tony Nguyen
> Sent: Friday, September 8, 2023 10:11 PM
> To: poros <poros@...hat.com>; netdev@...r.kernel.org
> Cc: ivecera <ivecera@...hat.com>; Brandeburg, Jesse
> <jesse.brandeburg@...el.com>; linux-kernel@...r.kernel.org;
> edumazet@...gle.com; intel-wired-lan@...ts.osuosl.org; horms@...nel.org;
> kuba@...nel.org; pabeni@...hat.com; davem@...emloft.net
> Subject: Re: [Intel-wired-lan] [PATCH net v2 2/2] iavf: schedule a request
> immediately after add/delete vlan
> 
> 
> 
> On 9/7/2023 8:02 AM, Petr Oros wrote:
> > When the iavf driver wants to reconfigure the VLAN filters
> > (iavf_add_vlan, iavf_del_vlan), it sets a flag in
> > aq_required:
> >    adapter->aq_required |= IAVF_FLAG_AQ_ADD_VLAN_FILTER;
> > or:
> >    adapter->aq_required |= IAVF_FLAG_AQ_DEL_VLAN_FILTER;
> >
> > This is later processed by the watchdog_task, but it runs periodically
> > every 2 seconds, so it can be a long time before it processes the request.
> >
> > In the worst case, the interface is unable to receive traffic for more
> > than 2 seconds for no objective reason.
> >
> 
> Changes look ok, however, can you supply or add a Fixes:?
> 
> > Signed-off-by: Petr Oros <poros@...hat.com>
> > Co-developed-by: Michal Schmidt <mschmidt@...hat.com>
> > Signed-off-by: Michal Schmidt <mschmidt@...hat.com>
> > Co-developed-by: Ivan Vecera <ivecera@...hat.com>
> > Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> > Reviewed-by: Ahmed Zaki <ahmed.zaki@...el.com>
> > ---
> >   drivers/net/ethernet/intel/iavf/iavf_main.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > index 86d472dfdbc10c..d9f8ac1d57fd62 100644
> > --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> > +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> > @@ -821,7 +821,7 @@ iavf_vlan_filter *iavf_add_vlan(struct iavf_adapter


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>