netdev - Re: [net-next PATCH v3 01/10] netdev-genl: spec: Extend netdev netlink spec in YAML for queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Sep 2023 16:06:04 -0700
From: "Nambiar, Amritha" <amritha.nambiar@...el.com>
To: Paolo Abeni <pabeni@...hat.com>, <netdev@...r.kernel.org>,
	<kuba@...nel.org>
CC: <sridhar.samudrala@...el.com>
Subject: Re: [net-next PATCH v3 01/10] netdev-genl: spec: Extend netdev
 netlink spec in YAML for queue

On 9/28/2023 3:33 AM, Paolo Abeni wrote:
> On Tue, 2023-09-19 at 15:27 -0700, Amritha Nambiar wrote:
>> Add support in netlink spec(netdev.yaml) for queue information.
>> Add code generated from the spec.
>>
>> Note: The "q-type" attribute currently takes values 0 and 1 for rx
>> and tx queue type respectively. I haven't figured out the ynl
>> library changes to support string user input ("rx" and "tx") to
>> enum value conversion in the generated file.
>>
>> Signed-off-by: Amritha Nambiar <amritha.nambiar@...el.com>
>> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@...el.com>
>> ---
>>   Documentation/netlink/specs/netdev.yaml |   52 ++++++++++
>>   include/uapi/linux/netdev.h             |   17 +++
>>   net/core/netdev-genl-gen.c              |   26 +++++
>>   net/core/netdev-genl-gen.h              |    3 +
>>   net/core/netdev-genl.c                  |   10 ++
>>   tools/include/uapi/linux/netdev.h       |   17 +++
>>   tools/net/ynl/generated/netdev-user.c   |  159 +++++++++++++++++++++++++++++++
>>   tools/net/ynl/generated/netdev-user.h   |  101 ++++++++++++++++++++
>>   8 files changed, 385 insertions(+)
>>
>> diff --git a/Documentation/netlink/specs/netdev.yaml b/Documentation/netlink/specs/netdev.yaml
>> index c46fcc78fc04..7b5d4cdff48b 100644
>> --- a/Documentation/netlink/specs/netdev.yaml
>> +++ b/Documentation/netlink/specs/netdev.yaml
>> @@ -55,6 +55,10 @@ definitions:
>>           name: hash
>>           doc:
>>             Device is capable of exposing receive packet hash via bpf_xdp_metadata_rx_hash().
>> +  -
>> +    name: queue-type
>> +    type: enum
>> +    entries: [ rx, tx ]
>>   
>>   attribute-sets:
>>     -
>> @@ -89,6 +93,32 @@ attribute-sets:
>>           enum: xdp-rx-metadata
>>           enum-as-flags: true
>>   
>> +  -
>> +    name: queue
>> +    attributes:
>> +      -
>> +        name: q-id
> 
> Why not 'queue-id' or 'id'?
> 

Okay, I will change this to 'queue-id'.

>> +        doc: queue index
>> +        type: u32
>> +      -
>> +        name: ifindex
>> +        doc: netdev ifindex
>> +        type: u32
>> +        checks:
>> +          min: 1
>> +      -
>> +        name: q-type
> 
> Same here?
> 

Will change to 'queue-type'.

> 
> 
> Cheers,
> 
> Paolo
> 
>