| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Oct 2023 10:54:26 +0300
From: Tariq Toukan <ttoukan.linux@...il.com>
To: Christian Marangi <ansuelsmth@...il.com>, Jason Gunthorpe <jgg@...pe.ca>,
Leon Romanovsky <leon@...nel.org>, Wolfgang Grandegger <wg@...ndegger.com>,
Marc Kleine-Budde <mkl@...gutronix.de>, "David S. Miller"
<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Chris Snook <chris.snook@...il.com>, Raju Rangoju <rajur@...lsio.com>,
Jeroen de Borst <jeroendb@...gle.com>,
Praveen Kaligineedi <pkaligineedi@...gle.com>,
Shailend Chand <shailend@...gle.com>, Douglas Miller
<dougmill@...ux.ibm.com>, Nick Child <nnac123@...ux.ibm.com>,
Michael Ellerman <mpe@...erman.id.au>, Nicholas Piggin <npiggin@...il.com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Haren Myneni <haren@...ux.ibm.com>, Rick Lindsley <ricklind@...ux.ibm.com>,
Dany Madden <danymadden@...ibm.com>, Thomas Falcon <tlfalcon@...ux.ibm.com>,
Tariq Toukan <tariqt@...dia.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Krzysztof Halasa <khalasa@...p.pl>, Kalle Valo <kvalo@...nel.org>,
Jeff Johnson <quic_jjohnson@...cinc.com>,
Gregory Greenman <gregory.greenman@...el.com>,
Chandrashekar Devegowda <chandrashekar.devegowda@...el.com>,
Intel Corporation <linuxwwan@...el.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@...ux.intel.com>,
Liu Haijun <haijun.liu@...iatek.com>,
M Chetan Kumar <m.chetan.kumar@...ux.intel.com>,
Ricardo Martinez <ricardo.martinez@...ux.intel.com>,
Loic Poulain <loic.poulain@...aro.org>,
Sergey Ryazanov <ryazanov.s.a@...il.com>,
Johannes Berg <johannes@...solutions.net>,
Yuanjun Gong <ruc_gongyuanjun@....com>, Alex Elder <elder@...aro.org>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>, Simon Horman <horms@...nel.org>,
Rob Herring <robh@...nel.org>, Bailey Forrest <bcf@...gle.com>,
Junfeng Guo <junfeng.guo@...el.com>,
"Gustavo A. R. Silva" <gustavoars@...nel.org>,
Ziwei Xiao <ziweixiao@...gle.com>, Rushil Gupta <rushilg@...gle.com>,
Thomas Gleixner <tglx@...utronix.de>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Yuri Karpov <YKarpov@...ras.ru>, Andrew Lunn <andrew@...n.ch>,
Zheng Zengkai <zhengzengkai@...wei.com>, Dawei Li <set_pte_at@...look.com>,
Anjaneyulu <pagadala.yesu.anjaneyulu@...el.com>,
Benjamin Berg <benjamin.berg@...el.com>, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, ath10k@...ts.infradead.org,
linux-wireless@...r.kernel.org
Subject: Re: [net-next v3 3/5] netdev: replace napi_reschedule with
napi_schedule
On 09/10/2023 16:37, Christian Marangi wrote:
> Now that napi_schedule return a bool, we can drop napi_reschedule that
> does the same exact function. The function comes from a very old commit
> bfe13f54f502 ("ibm_emac: Convert to use napi_struct independent of struct
> net_device") and the purpose is actually deprecated in favour of
> different logic.
>
> Convert every user of napi_reschedule to napi_schedule.
>
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com> # ath10k
> Acked-by: Nick Child <nnac123@...ux.ibm.com> # ibm
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de> # for can/dev/rx-offload.c
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> ---
> Changes v3:
> - Add Reviewed-by tag
> Changes v2:
> - Add ack tag
> ---
> drivers/infiniband/ulp/ipoib/ipoib_ib.c | 4 ++--
> drivers/net/can/dev/rx-offload.c | 2 +-
> drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +-
> drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 2 +-
> drivers/net/ethernet/ezchip/nps_enet.c | 2 +-
> drivers/net/ethernet/google/gve/gve_main.c | 2 +-
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
> drivers/net/ethernet/ibm/emac/mal.c | 2 +-
> drivers/net/ethernet/ibm/ibmveth.c | 2 +-
> drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
> drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +-
> drivers/net/ethernet/ni/nixge.c | 2 +-
> drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c | 2 +-
> drivers/net/ethernet/xscale/ixp4xx_eth.c | 4 ++--
> drivers/net/fjes/fjes_main.c | 2 +-
> drivers/net/wan/ixp4xx_hss.c | 4 ++--
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> drivers/net/wwan/t7xx/t7xx_hif_dpmaif_rx.c | 2 +-
> include/linux/netdevice.h | 10 ----------
> 19 files changed, 21 insertions(+), 31 deletions(-)
>
...
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 332472fe4990..a09b6e05337d 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -400,7 +400,7 @@ void mlx4_en_recover_from_oom(struct mlx4_en_priv *priv)
> for (ring = 0; ring < priv->rx_ring_num; ring++) {
> if (mlx4_en_is_ring_empty(priv->rx_ring[ring])) {
> local_bh_disable();
> - napi_reschedule(&priv->rx_cq[ring]->napi);
> + napi_schedule(&priv->rx_cq[ring]->napi);
> local_bh_enable();
> }
> }
For mlx4 part:
Acked-by: Tariq Toukan <tariqt@...dia.com>
Powered by blists - more mailing lists