netdev - Re: [PATCH][ncsi] Revert NCSI link loss/gain commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 8 Nov 2023 18:06:12 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Johnathan Mantey <johnathanx.mantey@...el.com>
Cc: <netdev@...r.kernel.org>
Subject: Re: [PATCH][ncsi] Revert NCSI link loss/gain commit

On Wed, 8 Nov 2023 14:29:43 -0800 Johnathan Mantey wrote:
> The NCSI commit
> ncsi: Propagate carrier gain/loss events to the NCSI controller
> introduced unwanted behavior.
> 
> The intent for the commit was to be able to detect carrier loss/gain
> for just the NIC connected to the BMC. The unwanted effect is a
> carrier loss for auxiliary paths also causes the BMC to lose
> carrier. The BMC never regains carrier despite the secondary NIC
> regaining a link.
> 
> This change, when merged, needs to be backported to stable kernels.

You need to add a Fixes tag (pointing at the reverted change), 
and a CC: stable tag. Here's an example of a well formatted fix:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=02d5fdbf4f2b8c406f7a4c98fa52aa181a11d733

When you repost make sure you use get_maintainers on the patch file, 
to catch all reviewers. And put [PATCH net v2] ncsi: Revert...
as the subject.
-- 
pw-bot: cr