[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 11 Nov 2023 18:40:52 +0000
From: Simon Horman <horms@...nel.org>
To: Ivan Vecera <ivecera@...hat.com>
Cc: intel-wired-lan@...ts.osuosl.org,
Jacob Keller <jacob.e.keller@...el.com>,
Wojciech Drewek <wojciech.drewek@...el.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Todd Fujinaka <todd.fujinaka@...el.com>,
Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
"open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH iwl-net] i40e: Fix unexpected MFS warning message
On Fri, Nov 10, 2023 at 09:12:09AM +0100, Ivan Vecera wrote:
> Commit 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set") added
> a warning message that reports unexpected size of port's MFS (max
> frame size) value. This message use for the port number local
> variable 'i' that is wrong.
> In i40e_probe() this 'i' variable is used only to iterate VSIs
> to find FDIR VSI:
>
> <code>
> ...
> /* if FDIR VSI was set up, start it now */
> for (i = 0; i < pf->num_alloc_vsi; i++) {
> if (pf->vsi[i] && pf->vsi[i]->type == I40E_VSI_FDIR) {
> i40e_vsi_open(pf->vsi[i]);
> break;
> }
> }
> ...
> </code>
>
> So the warning message use for the port number indext of FDIR VSI
> if this exists or pf->num_alloc_vsi if not.
>
> Fix the message by using 'pf->hw.port' for the port number.
>
> Fixes: 3a2c6ced90e1 ("i40e: Add a check to see if MFS is set")
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
Thanks Ivan,
I agree with your analysis that this change corrects the port number
printed. And that the problem is introduced in the cited commit.
Reviewed-by: Simon Horman <horms@...nel.org>
Powered by blists - more mailing lists