netdev - Re: [PATCH net-next v4 00/13] net: page_pool: add netlink-based introspection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 Nov 2023 16:03:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Eric Dumazet <edumazet@...gle.com>
Cc: Daniel Golle <daniel@...rotopia.org>,
 patchwork-bot+netdevbpf@...nel.org, davem@...emloft.net,
 netdev@...r.kernel.org, pabeni@...hat.com, hawk@...nel.org,
 ilias.apalodimas@...aro.org, dsahern@...il.com, dtatulea@...dia.com,
 willemb@...gle.com, almasrymina@...gle.com, shakeelb@...gle.com
Subject: Re: [PATCH net-next v4 00/13] net: page_pool: add netlink-based
 introspection

On Wed, 29 Nov 2023 22:12:49 +0100 Eric Dumazet wrote:
> Please look at the syzbot report
> 
> Proposed patch was :
> 
> diff --git a/net/core/page_pool_user.c b/net/core/page_pool_user.c
> index 1426434a7e1587797da92f3199c0012559b51271..07becd4eceddcd4be9e5bea6479f8ffd16dac851
> 100644
> --- a/net/core/page_pool_user.c
> +++ b/net/core/page_pool_user.c
> @@ -339,7 +339,8 @@ void page_pool_unlist(struct page_pool *pool)
>         mutex_lock(&page_pools_lock);
>         netdev_nl_page_pool_event(pool, NETDEV_CMD_PAGE_POOL_DEL_NTF);
>         xa_erase(&page_pools, pool->user.id);
> -       hlist_del(&pool->user.list);
> +       if (!hlist_unhashed(&pool->user.list))
> +               hlist_del(&pool->user.list);
>         mutex_unlock(&page_pools_lock);
>  }


Any reason not to post this fix?