netdev - RE: [PATCH net-next v4 2/9] net: rswitch: Use unsigned int for desc related array index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 8 Dec 2023 03:59:05 +0000
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To: Sergey Shtylyov <s.shtylyov@....ru>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>
Subject: RE: [PATCH net-next v4 2/9] net: rswitch: Use unsigned int for desc
 related array index

Hello Sergey,

> From: Sergey Shtylyov, Sent: Thursday, December 7, 2023 6:09 PM
> 
> On 12/7/23 11:12 AM, Yoshihiro Shimoda wrote:
> 
> > Array index should not be negative, so use unsigned int for
> > descriptors related array index.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> > ---
> >  drivers/net/ethernet/renesas/Makefile  |  1 -
> >  drivers/net/ethernet/renesas/rswitch.c | 88 ++++++++++++++------------
> >  drivers/net/ethernet/renesas/rswitch.h | 14 ++--
> >  3 files changed, 56 insertions(+), 47 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/renesas/Makefile b/drivers/net/ethernet/renesas/Makefile
> > index 9070acfd6aaf..f9cfd9750c1c 100644
> > --- a/drivers/net/ethernet/renesas/Makefile
> > +++ b/drivers/net/ethernet/renesas/Makefile
> > @@ -2,7 +2,6 @@
> >  #
> >  # Makefile for the Renesas network device drivers
> >  #
> > -
> 
>    Unrelated whitespace change. :-/

Oops. I'll drop this on v5.

Best regards,
Yoshihiro Shimoda

> >  obj-$(CONFIG_SH_ETH) += sh_eth.o
> [...]
> 
> MBR, Sergey