netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix PF with enabled XDP going no-carrier after reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 09:11:32 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brandeburg, Jesse"
	<jesse.brandeburg@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>, "Kuruvinakunnel,
 George" <george.kuruvinakunnel@...el.com>, "Nagraj, Shravan"
	<shravan.nagraj@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "Sreenivas, Bharathi"
	<bharathi.sreenivas@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Fix PF with enabled XDP
 going no-carrier after reset



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Zaremba, Larysa
>Sent: Tuesday, December 12, 2023 2:59 PM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: Zaremba, Larysa <larysa.zaremba@...el.com>; netdev@...r.kernel.org;
>Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
><przemyslaw.kitszel@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>;
>Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
>Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix PF with enabled XDP going
>no-carrier after reset
>
>Commit 6624e780a577fc596788 ("ice: split ice_vsi_setup into smaller
>functions") has refactored a bunch of code involved in PFR. In this process, TC
>queue number adjustment for XDP was lost. Bring it back.
>
>Lack of such adjustment causes interface to go into no-carrier after a reset, if
>XDP program is attached, with the following message:
>
>ice 0000:b1:00.0: Failed to set LAN Tx queue context, error: -22 ice
>0000:b1:00.0 ens801f0np0: Failed to open VSI 0x0006 on switch 0x0001 ice
>0000:b1:00.0: enable VSI failed, err -22, VSI index 0, type ICE_VSI_PF ice
>0000:b1:00.0: PF VSI rebuild failed: -22 ice 0000:b1:00.0: Rebuild failed,
>unload and reload driver
>
>Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_lib.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)