netdev - Re: [PATCH v2 2/4] net: ethernet: altera: fix indentation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 23 Dec 2023 14:57:36 +0000
From: Simon Horman <horms@...nel.org>
To: deepakx.nagaraju@...el.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	jdavem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
	mun.yew.tham@...el.com,
	Andy Schevchenko <andriy.schevchenko@...ux.intel.com>
Subject: Re: [PATCH v2 2/4] net: ethernet: altera: fix indentation warnings

On Thu, Dec 21, 2023 at 09:40:39PM +0800, deepakx.nagaraju@...el.com wrote:
> From: Nagaraju DeepakX <deepakx.nagaraju@...el.com>
> 
> Fix indentation issues such as missing a blank line after declarations
> and alignment issues.
> 
> Signed-off-by: Nagaraju DeepakX <deepakx.nagaraju@...el.com>
> Reviewed-by: Andy Schevchenko <andriy.schevchenko@...ux.intel.com>

...

> diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
> index 1c8763be0e4b..6a1a004ea693 100644
> --- a/drivers/net/ethernet/altera/altera_tse_main.c
> +++ b/drivers/net/ethernet/altera/altera_tse_main.c
> @@ -258,14 +258,12 @@ static int alloc_init_skbufs(struct altera_tse_private *priv)
>  	int i;
> 
>  	/* Create Rx ring buffer */
> -	priv->rx_ring = kcalloc(rx_descs, sizeof(struct tse_buffer),
> -				GFP_KERNEL);
> +	priv->rx_ring = kcalloc(rx_descs, sizeof(struct tse_buffer), GFP_KERNEL);
>  	if (!priv->rx_ring)
>  		goto err_rx_ring;
> 
>  	/* Create Tx ring buffer */
> -	priv->tx_ring = kcalloc(tx_descs, sizeof(struct tse_buffer),
> -				GFP_KERNEL);
> +	priv->tx_ring = kcalloc(tx_descs, sizeof(struct tse_buffer), GFP_KERNEL);

Hi,

Networking still prefers code that is less than 80 columns wide.
So I think the above changes are not desirable.

The rest of the patch looks find to me, assuming the maintainers want to
take cosmetic changes of this nature. Which, personally, I lean to thinking
is ok in the context of the rest of this patch-set.

>  	if (!priv->tx_ring)
>  		goto err_tx_ring;
> 

...