netdev - RE: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with "link-down-on-close" enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 27 Dec 2023 02:18:19 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Drewek, Wojciech" <wojciech.drewek@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with
 "link-down-on-close" enabled

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Wojciech Drewek
> Sent: Friday, December 15, 2023 4:32 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org
> Subject: [Intel-wired-lan] [PATCH iwl-net 2/2] ice: Shut down VSI with "link-down-on-close" enabled
>
> From: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
>
> Disabling netdev with ethtool private flag "link-down-on-close" enabled
> can cause NULL pointer dereference bug. Shut down VSI regardless of
> "link-down-on-close" state.
>
> Fixes: 8ac7132704f3 ("ice: Fix interface being down after reset with link-down-on-close flag on")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Signed-off-by: Ngai-Mint Kwan <ngai-mint.kwan@...el.com>
> Signed-off-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
>  1 file changed, 2 insertions(+)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)