netdev - Re: [PATCH net-next v7 9/9] net: stmmac: Disable coe for some Loongson GNET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 20:47:40 +0800
From: Yanteng Si <siyanteng@...ngson.cn>
To: Serge Semin <fancer.lancer@...il.com>
Cc: andrew@...n.ch, hkallweit1@...il.com, peppe.cavallaro@...com,
 alexandre.torgue@...s.st.com, joabreu@...opsys.com, Jose.Abreu@...opsys.com,
 chenhuacai@...ngson.cn, linux@...linux.org.uk, guyinggang@...ngson.cn,
 netdev@...r.kernel.org, chris.chenfeiyang@...il.com
Subject: Re: [PATCH net-next v7 9/9] net: stmmac: Disable coe for some
 Loongson GNET


在 2023/12/21 10:36, Serge Semin 写道:
> On Tue, Dec 19, 2023 at 10:28:19PM +0800, Yanteng Si wrote:
>> Some chips of Loongson GNET does not support coe, so disable them.
>>
>> Signed-off-by: Yanteng Si <siyanteng@...ngson.cn>
>> Signed-off-by: Feiyang Chen <chenfeiyang@...ngson.cn>
>> Signed-off-by: Yinggang Gu <guyinggang@...ngson.cn>
>> ---
>>   drivers/net/ethernet/stmicro/stmmac/hwif.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> index 3724cf698de6..f211880925aa 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c
>> @@ -73,6 +73,11 @@ static int stmmac_dwmac1_quirks(struct stmmac_priv *priv)
>>   		mac->desc = &ndesc_ops;
>>   	}
>>   
>> +	if (priv->synopsys_id == DWLGMAC_CORE_1_00) {
>> +		priv->plat->tx_coe = 0;
>> +		priv->plat->rx_coe = STMMAC_RX_COE_NONE;
>> +	}
> Couldn't this be done in dwmac-loongson.c?

Sorry for the late reply, I have been busy with patches 4 and 5.

I think I can give you a definite answer: This is possible, just like

the method you mentioned in patch 5, I only need to

overwrite ld->dwlgmac_dma_ops.get_hw_feature.


Thanks,

Yanteng

>
> -Serge(y)
>
>> +
>>   	stmmac_dwmac_mode_quirk(priv);
>>   	return 0;
>>   }
>> -- 
>> 2.31.4
>>