netdev - RE: [PATCH net-next 09/22] net: fill in MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 23 Jan 2024 01:33:23 +0000
From: Wei Fang <wei.fang@....com>
To: Breno Leitao <leitao@...ian.org>, "kuba@...nel.org" <kuba@...nel.org>,
	"davem@...emloft.net" <davem@...emloft.net>, "abeni@...hat.com"
	<abeni@...hat.com>, "edumazet@...gle.com" <edumazet@...gle.com>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>, dl-linux-imx
	<linux-imx@....com>, Paolo Abeni <pabeni@...hat.com>
CC: "dsahern@...nel.org" <dsahern@...nel.org>, "weiwan@...gle.com"
	<weiwan@...gle.com>, "open list:FREESCALE IMX / MXC FEC DRIVER"
	<netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec

> -----Original Message-----
> From: Breno Leitao <leitao@...ian.org>
> Sent: 2024年1月23日 2:46
> To: kuba@...nel.org; davem@...emloft.net; abeni@...hat.com;
> edumazet@...gle.com; Wei Fang <wei.fang@....com>; Shenwei Wang
> <shenwei.wang@....com>; Clark Wang <xiaoning.wang@....com>;
> dl-linux-imx <linux-imx@....com>; Paolo Abeni <pabeni@...hat.com>
> Cc: dsahern@...nel.org; weiwan@...gle.com; open list:FREESCALE IMX /
> MXC FEC DRIVER <netdev@...r.kernel.org>; open list
> <linux-kernel@...r.kernel.org>
> Subject: [PATCH net-next 09/22] net: fill in MODULE_DESCRIPTION()s for fec
> 
> W=1 builds now warn if module is built without a MODULE_DESCRIPTION().
> Add descriptions to the FEC (MPC8xx) Ethernet controller.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index d42594f32275..c56807b757dc 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -4769,4 +4769,5 @@ static struct platform_driver fec_driver = {
> 
>  module_platform_driver(fec_driver);
> 
> +MODULE_DESCRIPTION("Fast Ethernet Controller (FEC) MPC8xx Ethernet
> driver");

Thank you very much for this patch. It would be better if you change the
description to " NXP Fast Ethernet Controller (FEC) driver".

>  MODULE_LICENSE("GPL");
> --
> 2.39.3