netdev - Re: [PATCH net-next v6] bonding: Add independent control state machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 2 Feb 2024 08:17:58 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Aahil Awatramani <aahila@...gle.com>
Cc: David Dillow <dave@...dillows.org>,
	Mahesh Bandewar <maheshb@...gle.com>,
	Jay Vosburgh <j.vosburgh@...il.com>,
	Hangbin Liu <liuhangbin@...il.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Martin KaFai Lau <martin.lau@...nel.org>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6] bonding: Add independent control state
 machine

Thu, Feb 01, 2024 at 07:45:23PM CET, aahila@...gle.com wrote:
>> Any chance we can have some coverage via self-tests?
>
>I plan to work on these self-tests decoupled from the current patch.
>
>> Hmm, I wonder how it makes sense to add new features here. This should
>> rot.
>
>Could you clarify what you are suggesting here?

Don't touch procfs here.

>
>
>On Thu, Feb 1, 2024 at 8:28 AM Jiri Pirko <jiri@...nulli.us> wrote:
>>
>> Mon, Jan 29, 2024 at 09:27:41PM CET, aahila@...gle.com wrote:
>>
>> [...]
>>
>>
>> >diff --git a/drivers/net/bonding/bond_procfs.c b/drivers/net/bonding/bond_procfs.c
>> >index 43be458422b3..95d88df94756 100644
>> >--- a/drivers/net/bonding/bond_procfs.c
>> >+++ b/drivers/net/bonding/bond_procfs.c
>> >@@ -154,6 +154,8 @@ static void bond_info_show_master(struct seq_file *seq)
>> >                          (bond->params.lacp_active) ? "on" : "off");
>> >               seq_printf(seq, "LACP rate: %s\n",
>> >                          (bond->params.lacp_fast) ? "fast" : "slow");
>> >+              seq_printf(seq, "LACP coupled_control: %s\n",
>> >+                         (bond->params.coupled_control) ? "on" : "off");
>>
>> Hmm, I wonder how it makes sense to add new features here. This should
>> rot.
>>
>>
>> >               seq_printf(seq, "Min links: %d\n", bond->params.min_links);
>> >               optval = bond_opt_get_val(BOND_OPT_AD_SELECT,
>> >                                         bond->params.ad_select);
>>
>> [...]