netdev - Re: [net-next v9 1/4] wwan: core: Add WWAN fastboot port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 11 Feb 2024 20:10:59 +0100
From: Loic Poulain <loic.poulain@...aro.org>
To: Jinjian Song <songjinjian@...mail.com>
Cc: netdev@...r.kernel.org, alan.zhang1@...ocom.com, angel.huang@...ocom.com, 
	chandrashekar.devegowda@...el.com, chiranjeevi.rapolu@...ux.intel.com, 
	danielwinkler@...gle.com, davem@...emloft.net, edumazet@...gle.com, 
	felix.yan@...ocom.com, freddy.lin@...ocom.com, haijun.liu@...iatek.com, 
	jinjian.song@...ocom.com, joey.zhao@...ocom.com, johannes@...solutions.net, 
	kuba@...nel.org, letitia.tsai@...com, linux-kernel@...r.kernel.com, 
	liuqf@...ocom.com, m.chetan.kumar@...ux.intel.com, nmarupaka@...gle.com, 
	pabeni@...hat.com, pin-hao.huang@...com, ricardo.martinez@...ux.intel.com, 
	ryazanov.s.a@...il.com, vsankar@...ovo.com, zhangrc@...ocom.com
Subject: Re: [net-next v9 1/4] wwan: core: Add WWAN fastboot port type

On Mon, 5 Feb 2024 at 11:23, Jinjian Song <songjinjian@...mail.com> wrote:
>
> From: Jinjian Song <jinjian.song@...ocom.com>
>
> Add a new WWAN port that connects to the device fastboot protocol
> interface.
>
> Signed-off-by: Jinjian Song <jinjian.song@...ocom.com>

AFAIR, I already gave my tag for this change, please carry the tag
along versions.

Reviewed-by: Loic Poulain <loic.poulain@...aro.org>



> ---
> v2-v9:
>  * no change
> ---
>  drivers/net/wwan/wwan_core.c | 4 ++++
>  include/linux/wwan.h         | 2 ++
>  2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c
> index 72e01e550a16..2ed20b20e7fc 100644
> --- a/drivers/net/wwan/wwan_core.c
> +++ b/drivers/net/wwan/wwan_core.c
> @@ -328,6 +328,10 @@ static const struct {
>                 .name = "XMMRPC",
>                 .devsuf = "xmmrpc",
>         },
> +       [WWAN_PORT_FASTBOOT] = {
> +               .name = "FASTBOOT",
> +               .devsuf = "fastboot",
> +       },
>  };
>
>  static ssize_t type_show(struct device *dev, struct device_attribute *attr,
> diff --git a/include/linux/wwan.h b/include/linux/wwan.h
> index 01fa15506286..170fdee6339c 100644
> --- a/include/linux/wwan.h
> +++ b/include/linux/wwan.h
> @@ -16,6 +16,7 @@
>   * @WWAN_PORT_QCDM: Qcom Modem diagnostic interface
>   * @WWAN_PORT_FIREHOSE: XML based command protocol
>   * @WWAN_PORT_XMMRPC: Control protocol for Intel XMM modems
> + * @WWAN_PORT_FASTBOOT: Fastboot protocol control
>   *
>   * @WWAN_PORT_MAX: Highest supported port types
>   * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type
> @@ -28,6 +29,7 @@ enum wwan_port_type {
>         WWAN_PORT_QCDM,
>         WWAN_PORT_FIREHOSE,
>         WWAN_PORT_XMMRPC,
> +       WWAN_PORT_FASTBOOT,
>
>         /* Add new port types above this line */
>
> --
> 2.34.1
>