netdev - Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 12 Feb 2024 09:40:38 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Shuah Khan <shuah@...nel.org>, Willem de
 Bruijn <willemb@...gle.com>,  Coco Li <lixiaoyan@...gle.com>,
 linux-kselftest@...r.kernel.org, Matthieu Baerts <matttbe@...nel.org>
Subject: Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test

On Fri, 2024-02-09 at 11:15 -0800, Jakub Kicinski wrote:
> On Wed,  7 Feb 2024 19:36:46 +0100 Paolo Abeni wrote:
> > +    if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]]; then
> > +        echo "Ignoring errors due to slow environment" 1>&2
> > +        exit_code=0
> > +    fi
> 
> Would it make sense to also add "&& $exit_code -ne 0" ?
> It may be useful to see in logs how many times we actually
> ignored the error?

Yep, I'll send a v3.

Thanks!

Paolo