netdev - Re: [PATCH] net: sfp: remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 13 Feb 2024 17:26:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>
Cc: Paolo Abeni <pabeni@...hat.com>, Daniil Dulov <d.dulov@...ddin.ru>,
 Heiner Kallweit <hkallweit1@...il.com>, "David S. Miller"
 <davem@...emloft.net>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: sfp: remove redundant NULL check

On Tue, 13 Feb 2024 13:43:57 +0100 Paolo Abeni wrote:
> On Sun, 2024-02-11 at 07:08 -0800, Daniil Dulov wrote:
> > bus->upstream_ops in sfp_register_bus() cannot be NULL. So remove
> > redundant NULL check.  
> 
> I'm unsure about that?!? in theory drivers could call
> sfp_bus_add_upstream()/phy_sfp_probe() with NULL ops, even it that very
> likely doesn't make any sense.
> 
> @Russel, @Andrew: WDYT?

Since Russell is AFK let me discard this instead of queuing.
We'll resurrect if any of the maintainers sends review tags or alike.