netdev - Re: [patch net-next] devlink: fix port dump cmd type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 20 Feb 2024 08:42:12 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Simon Horman <horms@...nel.org>, netdev@...r.kernel.org,
	pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com
Subject: Re: [patch net-next] devlink: fix port dump cmd type

Mon, Feb 19, 2024 at 09:20:38PM CET, kuba@...nel.org wrote:
>On Mon, 19 Feb 2024 15:13:43 +0000 Simon Horman wrote:
>> > Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.
>> > 
>> > Skimmed through devlink userspace implementations, none of them cares
>> > about this cmd value. Only ynl, for which, this is actually a fix, as it
>> > expects doit and dumpit ops rsp_value to be the same.  
>> 
>> I guess that in theory unknown implementations could exist.
>> But, ok :)
>
>I'd also prefer Fixes tag + net. YNL is user space, even if current YNL
>specs don't trigger it (I'm speculating that that's why you feel it's
>not a fix) someone may end up using YNL + YAML from 6.9 and expect it
>to work on 6.6 LTS.

As you wish.

>-- 
>pw-bot: cr