netdev - Re: [PATCH net] net/sched: flower: Add lock protection when remove filter handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 21 Feb 2024 08:06:02 +0000
From: Jianbo Liu <jianbol@...dia.com>
To: "jhs@...atatu.com" <jhs@...atatu.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>
CC: "davem@...emloft.net" <davem@...emloft.net>, Gal Pressman
	<gal@...dia.com>, Paul Blakey <paulb@...dia.com>, "marcelo.leitner@...il.com"
	<marcelo.leitner@...il.com>, "xiyou.wangcong@...il.com"
	<xiyou.wangcong@...il.com>, "pabeni@...hat.com" <pabeni@...hat.com>, Cosmin
 Ratiu <cratiu@...dia.com>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "horms@...nel.org"
	<horms@...nel.org>, "kuba@...nel.org" <kuba@...nel.org>
Subject: Re: [PATCH net] net/sched: flower: Add lock protection when remove
 filter handle

On Tue, 2024-02-20 at 09:53 -0500, Jamal Hadi Salim wrote:
> On Tue, Feb 20, 2024 at 4:17 AM Jiri Pirko <jiri@...nulli.us> wrote:
> > 
> > Tue, Feb 20, 2024 at 09:59:28AM CET, jianbol@...dia.com wrote:
> > > As IDR can't protect itself from the concurrent modification,
> > > place
> > > idr_remove() under the protection of tp->lock.
> > > 
> > > Fixes: 08a0063df3ae ("net/sched: flower: Move filter handle
> > > initialization earlier")
> > > Signed-off-by: Jianbo Liu <jianbol@...dia.com>
> > > Reviewed-by: Cosmin Ratiu <cratiu@...dia.com>
> > > Reviewed-by: Gal Pressman <gal@...dia.com>
> > 
> > Reviewed-by: Jiri Pirko <jiri@...dia.com>
> 
> Acked-by: Jamal Hadi Salim <jhs@...atatu.com>
> 
> Jianbo,  do you have a new test case that caught this that we can
> use?
> Just curious why it hasnt been caught earlier (it's been there for
> about a year).

I don't have the test case, sorry.
The issue was caught when we stressed performance on BlueField-3.

Thanks!
Jianbo

> 
> cheers,
> jamal