netdev - Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 25 Feb 2024 21:15:49 +0100
From: Joel Granados <j.granados@...sung.com>
To: <wenyang.linux@...mail.com>
CC: Luis Chamberlain <mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>,
	Christian Brauner <brauner@...nel.org>, <davem@...emloft.net>, David Ahern
	<dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/8] introduce sysctl SYSCTL_U8_MAX and
 SYSCTL_LONG_S32_MAX

On Sun, Feb 25, 2024 at 12:05:30PM +0800, wenyang.linux@...mail.com wrote:
> From: Wen Yang <wenyang.linux@...mail.com>
> 
> The boundary check of multiple modules uses these static variables (such as
> two_five_five, n_65535, ue_int_max, etc), and they are also not changed.
> Therefore, add them to the shared sysctl_vals and sysctl_long_vals to avoid
> duplication.

Having a hard time understanding what you are trying to do here: is it
that there are variables that are being defined statically in two (or
more) different files and you want to consolidate them into sysctl
variables?

> This also reduce the size a bit 
What size are you referring to? by how much?

The cover letter came separately and the patches are replying to a
non-existent mail. Is this due to some funkiness that Tencent does tot
he outgoing mail?

> 
> Wen Yang (8):
>   sysctl: introduce sysctl SYSCTL_U8_MAX and SYSCTL_LONG_S32_MAX
>   rxrpc: delete these duplicate static variables n_65535 and four
>   net: ipv6: delete these duplicate static variables two_five_five and
>     minus_one
>   svcrdma: delete the duplicate static variables zero
>   sysctl: delete these duplicate static variables i_zero and
>     i_one_hundred
>   epoll: delete these duplicate static variables long_zero and long_max
>   fs: inotify: delete these duplicate static variables it_zero and
>     it_int_max
>   ucounts: delete these duplicate static variables ue_zero and
>     ue_int_max
> 
>  fs/eventpoll.c                   |  7 ++-----
>  fs/notify/inotify/inotify_user.c | 11 ++++-------
>  include/linux/sysctl.h           | 15 +++++++++------
>  kernel/sysctl.c                  |  4 ++--
>  kernel/ucount.c                  |  7 ++-----
>  lib/test_sysctl.c                |  6 ++----
>  net/ipv6/addrconf.c              | 12 +++++-------
>  net/rxrpc/sysctl.c               | 16 +++++++---------
>  net/sunrpc/xprtrdma/svc_rdma.c   | 21 ++++++++++-----------
>  9 files changed, 43 insertions(+), 56 deletions(-)
> 
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Joel Granados <j.granados@...sung.com>
> Cc: Christian Brauner <brauner@...nel.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: David Ahern <dsahern@...nel.org>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> 
> -- 
> 2.25.1
> 

-- 

Joel Granados

Download attachment "signature.asc" of type "application/pgp-signature" (660 bytes)