netdev - Re: net: fman: Use common error handling code in dtsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 28 Feb 2024 09:43:35 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jiri Pirko <jiri@...nulli.us>,
 Madalin Bucur <madalin.bucur@....com>, Paolo Abeni <pabeni@...hat.com>,
 Sean Anderson <sean.anderson@...o.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: net: fman: Use common error handling code in dtsec_init()

>> Adjust jump targets so that a bit of exception handling can be better
>> reused at the end of this function implementation.
>
> Okay, but..
>
>>  .../net/ethernet/freescale/fman/fman_dtsec.c  | 19 +++++++++++--------
>>  1 file changed, 11 insertions(+), 8 deletions(-)
>
> ..you've added more lines than you've removed so what's the point.

* Can the change acceptance grow any more for attempts to improve error handling
  another bit?

* Would you like to fiddle with scope-based resource management?
  https://elixir.bootlin.com/linux/v6.8-rc6/source/include/linux/cleanup.h#L8

  See also:
  Article by Jonathan Corbet from 2023-06-15
  https://lwn.net/Articles/934679/

> --
> pw-bot: reject

Can such an reaction be reconsidered once more?

Regards,
Markus