netdev - RE: [Intel-wired-lan] [PATCH iwl-net 1/3] ixgbe: {dis, en}able irqs in ixgbe_txrx_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 13:01:46 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Pavel Vazharov <pavel@...e.net>, "Karlsson,
 Magnus" <magnus.karlsson@...el.com>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>,
	"Nagraj, Shravan" <shravan.nagraj@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 1/3] ixgbe: {dis, en}able irqs
 in ixgbe_txrx_ring_{dis, en}able



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Wednesday, February 21, 2024 3:16 AM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: netdev@...r.kernel.org; Fijalkowski, Maciej
><maciej.fijalkowski@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Pavel Vazharov <pavel@...e.net>; Karlsson,
>Magnus <magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH iwl-net 1/3] ixgbe: {dis, en}able irqs in
>ixgbe_txrx_ring_{dis, en}able
>
>Currently routines that are supposed to toggle state of ring pair do not take
>care of associated interrupt with queue vector that these rings belong to. This
>causes funky issues such as dead interface due to irq misconfiguration, as per
>Pavel's report from Closes: tag.
>
>Add a function responsible for disabling single IRQ in EIMC register and call this
>as a very first thing when disabling ring pair during xsk_pool setup. For enable
>let's reuse ixgbe_irq_enable_queues(). Besides this, disable/enable NAPI as
>first/last thing when dealing with closing or opening ring pair that xsk_pool is
>being configured on.
>
>Reported-by: Pavel Vazharov <pavel@...e.net>
>Closes:
>https://lore.kernel.org/netdev/CAJEV1ijxNyPTwASJER1bcZzS9nMoZJqfR86nu
>_3jFFVXzZQ4NA@...l.gmail.com/
>Fixes: 024aa5800f32 ("ixgbe: added Rx/Tx ring disable/enable functions")
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 56 ++++++++++++++++---
> 1 file changed, 49 insertions(+), 7 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)