netdev - RE: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: reorder disabling IRQ and NAPI in ice_qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 02:21:41 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Karlsson, Magnus" <magnus.karlsson@...el.com>,
	"Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>, "Nagraj, Shravan"
	<shravan.nagraj@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: reorder disabling IRQ
 and NAPI in ice_qp_dis



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Fijalkowski, Maciej
>Sent: Wednesday, February 21, 2024 3:16 AM
>To: intel-wired-lan@...ts.osuosl.org
>Cc: netdev@...r.kernel.org; Fijalkowski, Maciej
><maciej.fijalkowski@...el.com>; Nguyen, Anthony L
><anthony.l.nguyen@...el.com>; Karlsson, Magnus
><magnus.karlsson@...el.com>
>Subject: [Intel-wired-lan] [PATCH iwl-net 3/3] ice: reorder disabling IRQ and
>NAPI in ice_qp_dis
>
>ice_qp_dis() currently does things in very mixed way. Tx is stopped before
>disabling IRQ on related queue vector, then it takes care of disabling Rx and
>finally NAPI is disabled.
>
>Let us start with disabling IRQs in the first place followed by turning off NAPI.
>Then it is safe to handle queues.
>
>One subtle change on top of that is that even though ice_qp_ena() looks more
>sane, clear ICE_CFG_BUSY as the last thing there.
>
>Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
>Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice_xsk.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)