netdev - RE: [PATCH v6 05/11 iwl-next] idpf: refactor remaining virtchnl messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 2 Mar 2024 04:37:37 +0000
From: "Singh, Krishneil K" <krishneil.k.singh@...el.com>
To: "Brady, Alan" <alan.brady@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Brady, Alan"
	<alan.brady@...el.com>, "Lobakin, Aleksander" <aleksander.lobakin@...el.com>
Subject: RE: [PATCH v6 05/11 iwl-next] idpf: refactor remaining virtchnl
 messages

> -----Original Message-----
> From: Alan Brady <alan.brady@...el.com>
> Sent: Thursday, February 22, 2024 11:05 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Brady, Alan <alan.brady@...el.com>; Lobakin,
> Aleksander <aleksander.lobakin@...el.com>
> Subject: [PATCH v6 05/11 iwl-next] idpf: refactor remaining virtchnl messages
> 
> This takes care of RSS/SRIOV/MAC and other misc virtchnl messages. This
> again is mostly mechanical.
> 
> In absence of an async_handler for MAC filters, this will simply
> generically report any errors from idpf_vc_xn_forward_async. This
> maintains the existing behavior. Follow up patch will add an async
> handler for MAC filters to remove bad filters from our list.
> 
> While we're here we can also make the code much nicer by converting some
> variables to auto-variables where appropriate. This makes it cleaner and
> less prone to memory leaking.
> 
> There's still a bit more cleanup we can do here to remove stuff that's
> not being used anymore now; follow-up patches will take care of loose
> ends.
> 
> Tested-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> Signed-off-by: Alan Brady <alan.brady@...el.com>
> ---
>  .../net/ethernet/intel/idpf/idpf_virtchnl.c   | 894 ++++++------------
>  1 file changed, 298 insertions(+), 596 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index 1d1b421c33a3..0f14860efa28 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c

Tested-by: Krishneil Singh <krishneil.k.singh@...el.com>