netdev - Re: [PATCH net-next 18/21] rxrpc: Use ktimes for call timeout tracking and set the timer lazily

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 03 Mar 2024 23:58:45 +0000
From: David Howells <dhowells@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Marc Dionne <marc.dionne@...istor.com>,
    "David S.
 Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 18/21] rxrpc: Use ktimes for call timeout tracking and set the timer lazily

Jakub Kicinski <kuba@...nel.org> wrote:

> > Track the call timeouts as ktimes rather than jiffies as the latter's
> > granularity is too high and only set the timer at the end of the event
> > handling function.
> 
> This one has a 64b div somewhere, breaks 32b builds.

Ah - in the trace functions to make the ns-level durations into ms-level ones.

I wonder if it's better to just divide by 1024 - so something close to
microseconds - or whether ktime_to_us() can be used there.

David