netdev - Re: [PATCH net-next v3] net: phy: qca807x: fix compilation when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 5 Mar 2024 16:03:55 +0000
From: Simon Horman <horms@...nel.org>
To: Robert Marko <robimarko@...il.com>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, andrew@...n.ch,
	hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	ansuelsmth@...il.com, linux-arm-msm@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net-next v3] net: phy: qca807x: fix compilation when
 CONFIG_GPIOLIB is not set

On Tue, Mar 05, 2024 at 03:20:33PM +0100, Robert Marko wrote:
> Kernel bot has discovered that if CONFIG_GPIOLIB is not set compilation
> will fail.
> 
> Upon investigation the issue is that qca807x_gpio() is guarded by a
> preprocessor check but then it is called under
> if (IS_ENABLED(CONFIG_GPIOLIB)) in the probe call so the compiler will
> error out since qca807x_gpio() has not been declared if CONFIG_GPIOLIB has
> not been set.
> 
> Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202403031332.IGAbZzwq-lkp@intel.com/
> Signed-off-by: Robert Marko <robimarko@...il.com>
> ---
> Changes in v3:
> * Target net-next tree
> Changes in v2:
> * Reduce the code indent level

Reviewed-by: Simon Horman <horms@...nel.org>
Tested-by: Simon Horman <horms@...nel.org> # build-tested