netdev - [PATCH iproute2-next] ss: fix the compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Thu,  7 Mar 2024 05:53:27 -0500
From: Denis Kirjanov <kirjanov@...il.com>
To: stephen@...workplumber.org,
	dsahern@...nel.org
Cc: netdev@...r.kernel.org,
	Denis Kirjanov <dkirjanov@...e.de>
Subject: [PATCH iproute2-next] ss: fix the compiler warning

the patch fixes the following compiler warning:

ss.c:1064:53: warning: format string is not a string literal [-Wformat-nonliteral]
        len = vsnprintf(pos, buf_chunk_avail(buffer.tail), fmt, _args);
                                                           ^~~
1 warning generated.
    LINK     ss

Fixes: e3ecf0485 ("ss: pretty-print BPF socket-local storage")
Signed-off-by: Denis Kirjanov <dkirjanov@...e.de>
---
 misc/ss.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/misc/ss.c b/misc/ss.c
index 87008d7c..038905f3 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -1042,6 +1042,7 @@ static int buf_update(int len)
 }
 
 /* Append content to buffer as part of the current field */
+__attribute__((format(printf, 1, 0)))
 static void vout(const char *fmt, va_list args)
 {
 	struct column *f = current_field;
-- 
2.30.2