netdev - RE: [Intel-wired-lan] [PATCH iwl-net] ice: Refactor FW data type and fix bitmap casting issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 08:21:55 +0000
From: "Buvaneswaran, Sujai" <sujai.buvaneswaran@...el.com>
To: "Zou, Steven" <steven.zou@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "Sokolowski, Jan" <jan.sokolowski@...el.com>, "jiri@...nulli.us"
	<jiri@...nulli.us>, "daniel.machon@...rochip.com"
	<daniel.machon@...rochip.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "Zou, Steven" <steven.zou@...el.com>, "Brandeburg,
 Jesse" <jesse.brandeburg@...el.com>, "Staikov, Andrii"
	<andrii.staikov@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "horms@...nel.org" <horms@...nel.org>, "Ertman,
 David M" <david.m.ertman@...el.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "andriy.shevchenko@...ux.intel.com"
	<andriy.shevchenko@...ux.intel.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] ice: Refactor FW data type and
 fix bitmap casting issue

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Steven Zou
> Sent: Wednesday, February 7, 2024 7:20 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: Sokolowski, Jan <jan.sokolowski@...el.com>; jiri@...nulli.us;
> daniel.machon@...rochip.com; netdev@...r.kernel.org; Zou, Steven
> <steven.zou@...el.com>; Brandeburg, Jesse <jesse.brandeburg@...el.com>;
> Staikov, Andrii <andrii.staikov@...el.com>; Lobakin, Aleksander
> <aleksander.lobakin@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; horms@...nel.org; Ertman, David M
> <david.m.ertman@...el.com>; Fijalkowski, Maciej
> <maciej.fijalkowski@...el.com>; andriy.shevchenko@...ux.intel.com; Kitszel,
> Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Refactor FW data type and fix
> bitmap casting issue
> 
> According to the datasheet, the recipe association data is an 8-byte little-
> endian value. It is described as 'Bitmap of the recipe indexes associated with
> this profile', it is from 24 to 31 byte area in FW.
> Therefore, it is defined to '__le64 recipe_assoc' in struct
> ice_aqc_recipe_to_profile. And then fix the bitmap casting issue, as we must
> never ever use castings for bitmap type.
> 
> Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
> bonded interface")
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> Reviewed-by: Andrii Staikov <andrii.staikov@...el.com>
> Reviewed-by: Jan Sokolowski <jan.sokolowski@...el.com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: Steven Zou <steven.zou@...el.com>
> ---
>  .../net/ethernet/intel/ice/ice_adminq_cmd.h   |  3 ++-
>  drivers/net/ethernet/intel/ice/ice_lag.c      |  4 ++--
>  drivers/net/ethernet/intel/ice/ice_switch.c   | 24 +++++++++++--------
>  drivers/net/ethernet/intel/ice/ice_switch.h   |  4 ++--
>  4 files changed, 20 insertions(+), 15 deletions(-)
> 
Tested-by: Sujai Buvaneswaran <sujai.buvaneswaran@...el.com>