netdev - Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 8 Mar 2024 20:02:18 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Jiri Pirko <jiri@...nulli.us>, Ivan Vecera <ivecera@...hat.com>, "David
 S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>, Eric
 Dumazet <edumazet@...gle.com>, Florian Fainelli <f.fainelli@...il.com>,
 Paolo Abeni <pabeni@...hat.com>, Vladimir Oltean <olteanv@...il.com>, Simon
 Horman <horms@...nel.org>, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error
 message clarity for switchdev_port_obj_add/del_deffered operations

On Fri,  8 Mar 2024 11:47:24 +0100 Oleksij Rempel wrote:
> +		problem = "Failure in VLAN settings on this port might disrupt "
> +		          "network segmentation or traffic isolation, affecting\n"
> +		          "network partitioning.\n";

nit: checkpatch spies with its little eye that there are spaces instead
of tabs here

FWIW I'd also personally go for splitting the string only where the \n
are, but that's up to you.
-- 
pw-bot: cr