netdev - Re: [PATCH net-next v3 4/4] net: gro: move L3 flush checks to tcp_gro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 11 Mar 2024 10:21:18 +0100
From: Richard Gobert <richardbgobert@...il.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, dsahern@...nel.org,
 xeb@...l.ru, shuah@...nel.org, idosch@...dia.com, razor@...ckwall.org,
 amcohen@...dia.com, petrm@...dia.com, jbenc@...hat.com, bpoirier@...dia.com,
 b.galvani@...il.com, gavinl@...dia.com, liujian56@...wei.com,
 horms@...nel.org, linyunsheng@...wei.com, therbert@...gle.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: gro: move L3 flush checks to
 tcp_gro_receive

Willem de Bruijn wrote:
> Richard Gobert wrote:
>> {inet,ipv6}_gro_receive functions perform flush checks (ttl, flags,
>> iph->id, ...) against all packets in a loop. These flush checks are
>> relevant only to tcp flows, and as such they're used to determine whether
>> the packets can be merged later in tcp_gro_receive.
>>
>> These checks are not relevant to UDP packets.
> 
> These are network protocol coalescing invariants. Why would they be
> limited to certain transport protocols only?

Thanks for the review, I'll fix the typos.
I replied to Eric's comment about the relevancy of these checks for UDP.