netdev - Re: memory leak in posix_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 15 Mar 2024 10:13:15 +0800
From: Z qiang <qiang.zhang1211@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: 柳菁峰 <liujingfeng@...nxin.com>, 
	"richardcochran@...il.com" <richardcochran@...il.com>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"syzkaller@...glegroups.com" <syzkaller@...glegroups.com>, "secalert@...hat.com" <secalert@...hat.com>
Subject: Re: memory leak in posix_clock_open

>
> On Mon, Mar 11 2024 at 17:46, Z qiang wrote:
> >
> > diff --git a/kernel/time/posix-clock.c b/kernel/time/posix-clock.c
> > index 9de66bbbb3d1..71d9d8c394fa 100644
> > --- a/kernel/time/posix-clock.c
> > +++ b/kernel/time/posix-clock.c
> > @@ -137,6 +137,8 @@ static int posix_clock_open(struct inode *inode,
> > struct file *fp)
> >
> >         if (!err) {
> >                 get_device(clk->dev);
> > +       } else {
> > +               kfree(pccontext);
> >         }
> >  out:
> >         up_read(&clk->rwsem);
>
> Looks about right. Can you please send a proper patch?

I will send a patch.

Thanks,
Zqiang