netdev - Re: [PATCH v2] lib/bitmap: Fix bitmap_scatter() and bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Mar 2024 14:43:18 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: Herve Codina <herve.codina@...tlin.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Yury Norov <yury.norov@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Networking <netdev@...r.kernel.org>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2] lib/bitmap: Fix bitmap_scatter() and bitmap_gather()
 kernel doc

On Thu, Mar 14, 2024 at 01:00:06PM +0100, Herve Codina wrote:
> diff --git a/include/linux/bitmap.h b/include/linux/bitmap.h
> index fb3a9c93ac86..aa4096126553 100644
> --- a/include/linux/bitmap.h
> +++ b/include/linux/bitmap.h
> @@ -522,17 +522,18 @@ static inline void bitmap_replace(unsigned long *dst,
>   *
>   * (Bits 0, 1, 2, 3, 4, 5 are copied to the bits 0, 1, 4, 8, 9, 12)
>   *
> - * A more 'visual' description of the operation:
> - * src:  0000000001011010
> - *                 ||||||
> - *          +------+|||||
> - *          |  +----+||||
> - *          |  |+----+|||
> - *          |  ||   +-+||
> - *          |  ||   |  ||
> - * mask: ...v..vv...v..vv
> - *       ...0..11...0..10
> - * dst:  0000001100000010
> + * A more 'visual' description of the operation::
> + *
> + *	src:  0000000001011010
> + *	                ||||||
> + *	         +------+|||||
> + *	         |  +----+||||
> + *	         |  |+----+|||
> + *	         |  ||   +-+||
> + *	         |  ||   |  ||
> + *	mask: ...v..vv...v..vv
> + *	      ...0..11...0..10
> + *	dst:  0000001100000010
>   *
>   * A relationship exists between bitmap_scatter() and bitmap_gather().
>   * bitmap_gather() can be seen as the 'reverse' bitmap_scatter() operation.
> @@ -568,16 +569,17 @@ static inline void bitmap_scatter(unsigned long *dst, const unsigned long *src,
>   *
>   * (Bits 0, 1, 4, 8, 9, 12 are copied to the bits 0, 1, 2, 3, 4, 5)
>   *
> - * A more 'visual' description of the operation:
> - * mask: ...v..vv...v..vv
> - * src:  0000001100000010
> - *          ^  ^^   ^   0
> - *          |  ||   |  10
> - *          |  ||   > 010
> - *          |  |+--> 1010
> - *          |  +--> 11010
> - *          +----> 011010
> - * dst:  0000000000011010
> + * A more 'visual' description of the operation::
> + *
> + *	mask: ...v..vv...v..vv
> + *	src:  0000001100000010
> + *	         ^  ^^   ^   0
> + *	         |  ||   |  10
> + *	         |  ||   > 010
> + *	         |  |+--> 1010
> + *	         |  +--> 11010
> + *	         +----> 011010
> + *	dst:  0000000000011010
>   *
>   * A relationship exists between bitmap_gather() and bitmap_scatter(). See
>   * bitmap_scatter() for the bitmap scatter detailed operations.

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)