netdev - RE: [EXTERNAL] Re: [PATCH v2 2/5] net: marvell: prestera: enlarge fw restart time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 17:24:12 +0000
From: Elad Nachman <enachman@...vell.com>
To: Andrew Lunn <andrew@...n.ch>
CC: Taras Chornyi <taras.chornyi@...ision.eu>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "kory.maincent@...tlin.com" <kory.maincent@...tlin.com>,
        "thomas.petazzoni@...tlin.com" <thomas.petazzoni@...tlin.com>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "przemyslaw.kitszel@...el.com" <przemyslaw.kitszel@...el.com>,
        "dkirjanov@...e.de" <dkirjanov@...e.de>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v2 2/5] net: marvell: prestera: enlarge fw
 restart time



> -----Original Message-----
> From: Andrew Lunn <andrew@...n.ch>
> Sent: Thursday, March 21, 2024 2:10 AM
> To: Elad Nachman <enachman@...vell.com>
> Cc: Taras Chornyi <taras.chornyi@...ision.eu>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> kory.maincent@...tlin.com; thomas.petazzoni@...tlin.com;
> miquel.raynal@...tlin.com; przemyslaw.kitszel@...el.com;
> dkirjanov@...e.de; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v2 2/5] net: marvell: prestera: enlarge fw
> restart time
> 
> Prioritize security for external emails: Confirm sender and content safety
> before clicking links or opening attachments
> 
> ----------------------------------------------------------------------
> On Wed, Mar 20, 2024 at 07:20:05PM +0200, Elad Nachman wrote:
> > From: Elad Nachman <enachman@...vell.com>
> >
> > Increase firmware restart timeout, as current timeout value of 5
> > seconds was too small, in actual life it can take up to 30 seconds for
> > firmware to shutdown and for the firmware loader to shift to the ready
> > to receive firmware code state.
> 
> So this means the probe can be waiting 30 seconds?
> 
> This seems like a really good reason not to reset the hardware during -
> EPROBE_DEFER.
> 
> 	Andrew

Unfortunately that's how the firmware loader on the firmware cpu state machine works.
The so called HW reset will force exit of the current firmware and will move the state machine
To the state that it can receive the next firmware.

Unfortunately, there is no ABI interface to verify which firmware is already loaded, and then supporting
Warm boot reading of the values back to the kernel.
Since many of these firmware binaries are secure-boot protected, upgrading is very tricky.

Elad.