netdev - Re: [PATCH v2] net: mark racy access on sk->sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 14:59:09 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: linke li <lilinke99@...com>
Cc: xujianhao01@...il.com, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Kuniyuki Iwashima <kuniyu@...zon.com>, Willem de Bruijn <willemb@...gle.com>, 
	Abel Wu <wuyun.abel@...edance.com>, Breno Leitao <leitao@...ian.org>, 
	Alexander Mikhalitsyn <alexander@...alicyn.com>, David Howells <dhowells@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: mark racy access on sk->sk_rcvbuf

On Thu, Mar 21, 2024 at 9:44 AM linke li <lilinke99@...com> wrote:
>
> sk->sk_rcvbuf in __sock_queue_rcv_skb() and __sk_receive_skb() can be
> changed by other threads. Mark this as benign using READ_ONCE().
>
> This patch is aimed at reducing the number of benign races reported by
> KCSAN in order to focus future debugging effort on harmful races.
>
> Signed-off-by: linke li <lilinke99@...com>
> ---
> v1 -> v2: include sk->sk_rcvbuf in __sock_queue_rcv_skb()

Reviewed-by: Eric Dumazet <edumazet@...gle.com>