netdev - Re: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ixgbe: Enable link management in E610 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 28 Mar 2024 06:12:14 +0800
From: kernel test robot <lkp@...el.com>
To: Piotr Kwapulinski <piotr.kwapulinski@...el.com>,
	intel-wired-lan@...ts.osuosl.org
Cc: oe-kbuild-all@...ts.linux.dev,
	Piotr Kwapulinski <piotr.kwapulinski@...el.com>,
	netdev@...r.kernel.org, Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Jan Glaza <jan.glaza@...el.com>,
	Jedrzej Jagielski <jedrzej.jagielski@...el.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ixgbe: Enable link
 management in E610 device

Hi Piotr,

kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.8]
[cannot apply to tnguy-next-queue/dev-queue tnguy-net-queue/dev-queue horms-ipvs/master v6.9-rc1 linus/master next-20240327]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Piotr-Kwapulinski/ixgbe-Add-support-for-E610-FW-Admin-Command-Interface/20240327-234237
base:   v6.8
patch link:    https://lore.kernel.org/r/20240327155422.25424-6-piotr.kwapulinski%40intel.com
patch subject: [Intel-wired-lan] [PATCH iwl-next v1 5/5] ixgbe: Enable link management in E610 device
config: loongarch-defconfig (https://download.01.org/0day-ci/archive/20240328/202403280523.pcRsyVNp-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240328/202403280523.pcRsyVNp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403280523.pcRsyVNp-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2822:5: warning: no previous prototype for 'ixgbe_set_fw_drv_ver_x550' [-Wmissing-prototypes]
    2822 | s32 ixgbe_set_fw_drv_ver_x550(struct ixgbe_hw *hw, u8 maj, u8 min,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3563:6: warning: no previous prototype for 'ixgbe_set_ethertype_anti_spoofing_x550' [-Wmissing-prototypes]
    3563 | void ixgbe_set_ethertype_anti_spoofing_x550(struct ixgbe_hw *hw,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:3584:6: warning: no previous prototype for 'ixgbe_set_source_address_pruning_x550' [-Wmissing-prototypes]
    3584 | void ixgbe_set_source_address_pruning_x550(struct ixgbe_hw *hw,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/ixgbe_set_ethertype_anti_spoofing_x550 +3563 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c

  3556	
  3557	/** ixgbe_set_ethertype_anti_spoofing_x550 - Enable/Disable Ethertype
  3558	 *	anti-spoofing
  3559	 *  @hw:  pointer to hardware structure
  3560	 *  @enable: enable or disable switch for Ethertype anti-spoofing
  3561	 *  @vf: Virtual Function pool - VF Pool to set for Ethertype anti-spoofing
  3562	 **/
> 3563	void ixgbe_set_ethertype_anti_spoofing_x550(struct ixgbe_hw *hw,
  3564						    bool enable, int vf)
  3565	{
  3566		int vf_target_reg = vf >> 3;
  3567		int vf_target_shift = vf % 8 + IXGBE_SPOOF_ETHERTYPEAS_SHIFT;
  3568		u32 pfvfspoof;
  3569	
  3570		pfvfspoof = IXGBE_READ_REG(hw, IXGBE_PFVFSPOOF(vf_target_reg));
  3571		if (enable)
  3572			pfvfspoof |= BIT(vf_target_shift);
  3573		else
  3574			pfvfspoof &= ~BIT(vf_target_shift);
  3575	
  3576		IXGBE_WRITE_REG(hw, IXGBE_PFVFSPOOF(vf_target_reg), pfvfspoof);
  3577	}
  3578	
  3579	/** ixgbe_set_source_address_pruning_x550 - Enable/Disbale src address pruning
  3580	 *  @hw: pointer to hardware structure
  3581	 *  @enable: enable or disable source address pruning
  3582	 *  @pool: Rx pool to set source address pruning for
  3583	 **/
> 3584	void ixgbe_set_source_address_pruning_x550(struct ixgbe_hw *hw,
  3585						   bool enable,
  3586						   unsigned int pool)
  3587	{
  3588		u64 pfflp;
  3589	
  3590		/* max rx pool is 63 */
  3591		if (pool > 63)
  3592			return;
  3593	
  3594		pfflp = (u64)IXGBE_READ_REG(hw, IXGBE_PFFLPL);
  3595		pfflp |= (u64)IXGBE_READ_REG(hw, IXGBE_PFFLPH) << 32;
  3596	
  3597		if (enable)
  3598			pfflp |= (1ULL << pool);
  3599		else
  3600			pfflp &= ~(1ULL << pool);
  3601	
  3602		IXGBE_WRITE_REG(hw, IXGBE_PFFLPL, (u32)pfflp);
  3603		IXGBE_WRITE_REG(hw, IXGBE_PFFLPH, (u32)(pfflp >> 32));
  3604	}
  3605	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki