netdev - Re: [PATCH v3 15/15] powerpc: Add support for suppressing warning backtraces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 04 Apr 2024 13:14:16 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: Guenter Roeck <linux@...ck-us.net>, linux-kselftest@...r.kernel.org
Cc: David Airlie <airlied@...il.com>, Arnd Bergmann <arnd@...db.de>,
 Maíra
 Canal <mcanal@...lia.com>, Dan Carpenter <dan.carpenter@...aro.org>, Kees
 Cook <keescook@...omium.org>, Daniel Diaz <daniel.diaz@...aro.org>, David
 Gow <davidgow@...gle.com>, Arthur Grillo <arthurgrillo@...eup.net>,
 Brendan Higgins <brendan.higgins@...ux.dev>, Naresh Kamboju
 <naresh.kamboju@...aro.org>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Maxime Ripard <mripard@...nel.org>, Ville
 Syrjälä <ville.syrjala@...ux.intel.com>, Daniel Vetter
 <daniel@...ll.ch>,
 Thomas Zimmermann <tzimmermann@...e.de>, dri-devel@...ts.freedesktop.org,
 kunit-dev@...glegroups.com, linux-arch@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
 linux-s390@...r.kernel.org, linux-sh@...r.kernel.org,
 loongarch@...ts.linux.dev, netdev@...r.kernel.org, x86@...nel.org, Guenter
 Roeck <linux@...ck-us.net>, Linux Kernel Functional Testing
 <lkft@...aro.org>
Subject: Re: [PATCH v3 15/15] powerpc: Add support for suppressing warning
 backtraces

Guenter Roeck <linux@...ck-us.net> writes:
> Add name of functions triggering warning backtraces to the __bug_table
> object section to enable support for suppressing WARNING backtraces.
>
> To limit image size impact, the pointer to the function name is only added
> to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and
> CONFIG_DEBUG_BUGVERBOSE are enabled. Otherwise, the __func__ assembly
> parameter is replaced with a (dummy) NULL parameter to avoid an image size
> increase due to unused __func__ entries (this is necessary because __func__
> is not a define but a virtual variable).
>
> Tested-by: Linux Kernel Functional Testing <lkft@...aro.org>
> Acked-by: Dan Carpenter <dan.carpenter@...aro.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v2:
> - Rebased to v6.9-rc1
> - Added Tested-by:, Acked-by:, and Reviewed-by: tags
> - Introduced KUNIT_SUPPRESS_BACKTRACE configuration option
> v3:
> - Rebased to v6.9-rc2
>
>  arch/powerpc/include/asm/bug.h | 37 +++++++++++++++++++++++++---------
>  1 file changed, 28 insertions(+), 9 deletions(-)

I ran it through some build and boot tests, LGTM.

Acked-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers