netdev - Re: [PATCH 2/2] ipv4/route: avoid unused-but-set-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 8 Apr 2024 10:47:15 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Arnd Bergmann <arnd@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Arnd Bergmann <arnd@...db.de>, 
	Kunwu Chan <chentao@...inos.cn>, Zhengchao Shao <shaozhengchao@...wei.com>, 
	Sriram Yagnaraman <sriram.yagnaraman@....tech>, Maxime Bizon <mbizon@...ebox.fr>, 
	Joel Granados <joel.granados@...il.com>, Kyle Zeng <zengyhkyle@...il.com>, 
	Beniamino Galvani <b.galvani@...il.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ipv4/route: avoid unused-but-set-variable warning

On Mon, Apr 8, 2024 at 9:42 AM Arnd Bergmann <arnd@...nel.org> wrote:
>
> From: Arnd Bergmann <arnd@...db.de>
>
> The log_martians variable is only used in an #ifdef, causing a 'make W=1'
> warning with gcc:
>
> net/ipv4/route.c: In function 'ip_rt_send_redirect':
> net/ipv4/route.c:880:13: error: variable 'log_martians' set but not used [-Werror=unused-but-set-variable]
>
> Change the #ifdef to an equivalent IS_ENABLED() to let the compiler
> see where the variable is used.
>
> Fixes: 30038fc61adf ("net: ip_rt_send_redirect() optimization")
> Reviewed-by: David Ahern <dsahern@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

A Fixes: tag like this seems overkill, I doubt W=1 was the norm for
old kernels...

Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks.