netdev - [PATCH iproute2-next 5/7] tc/util: remove unused argument from print_tcstats2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 13 Apr 2024 15:04:06 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: netdev@...r.kernel.org
Cc: Stephen Hemminger <stephen@...workplumber.org>
Subject: [PATCH iproute2-next 5/7] tc/util: remove unused argument from print_tcstats2_attr

The function doesn't use the FILE handle.

Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
---
 tc/m_action.c | 2 +-
 tc/tc_util.c  | 5 ++---
 tc/tc_util.h  | 3 +--
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/tc/m_action.c b/tc/m_action.c
index 6a361f11..feb869a9 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -396,7 +396,7 @@ static int tc_print_one_action(FILE *f, struct rtattr *arg, bool bind)
 		print_string(PRINT_FP, NULL, "\tAction statistics:", NULL);
 		print_nl();
 		open_json_object("stats");
-		print_tcstats2_attr(f, tb[TCA_ACT_STATS], "\t", NULL);
+		print_tcstats2_attr(tb[TCA_ACT_STATS], "\t", NULL);
 		close_json_object();
 		print_nl();
 	}
diff --git a/tc/tc_util.c b/tc/tc_util.c
index 133fe9f9..f9151408 100644
--- a/tc/tc_util.c
+++ b/tc/tc_util.c
@@ -708,8 +708,7 @@ static void print_tcstats_basic_hw(struct rtattr **tbs, const char *prefix)
 	print_uint(PRINT_ANY, "hw_packets", " %u pkt", bs_hw.packets);
 }
 
-void print_tcstats2_attr(FILE *fp, struct rtattr *rta,
-			 const char *prefix, struct rtattr **xstats)
+void print_tcstats2_attr(struct rtattr *rta, const char *prefix, struct rtattr **xstats)
 {
 	struct rtattr *tbs[TCA_STATS_MAX + 1];
 
@@ -790,7 +789,7 @@ void print_tcstats_attr(FILE *fp, struct rtattr *tb[], const char *prefix,
 			struct rtattr **xstats)
 {
 	if (tb[TCA_STATS2]) {
-		print_tcstats2_attr(fp, tb[TCA_STATS2], prefix, xstats);
+		print_tcstats2_attr(tb[TCA_STATS2], prefix, xstats);
 		if (xstats && !*xstats)
 			goto compat_xstats;
 		return;
diff --git a/tc/tc_util.h b/tc/tc_util.h
index de908d5e..2d38dd58 100644
--- a/tc/tc_util.h
+++ b/tc/tc_util.h
@@ -91,8 +91,7 @@ char *sprint_linklayer(unsigned int linklayer, char *buf);
 
 void print_tcstats_attr(FILE *fp, struct rtattr *tb[],
 			const char *prefix, struct rtattr **xstats);
-void print_tcstats2_attr(FILE *fp, struct rtattr *rta,
-			 const char *prefix, struct rtattr **xstats);
+void print_tcstats2_attr(struct rtattr *rta, const char *prefix, struct rtattr **xstats);
 
 int get_tc_classid(__u32 *h, const char *str);
 int print_tc_classid(char *buf, int len, __u32 h);
-- 
2.43.0