netdev - RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base instead of hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 23:11:48 +0000
From: "Brelinski, Tony" <tony.brelinski@...el.com>
To: Erwan Velu <erwanaliasr1@...il.com>
CC: "Velu, Erwan" <e.velu@...teo.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal
 base instead of hex

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Erwan Velu
> Sent: Tuesday, March 19, 2024 7:17 AM
> Cc: Velu, Erwan <e.velu@...teo.com>; linux-kernel@...r.kernel.org; Eric
> Dumazet <edumazet@...gle.com>; netdev@...r.kernel.org; Nguyen,
> Anthony L <anthony.l.nguyen@...el.com>; intel-wired-lan@...ts.osuosl.org;
> Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; David
> S. Miller <davem@...emloft.net>
> Subject: [Intel-wired-lan] [PATCH iwl-net] i40e: Report MFS in decimal base
> instead of hex
> 
> If the MFS is set below the default (0x2600), a warning message is reported
> like the following :
> 
> 	MFS for port 1 has been set below the default: 600
> 
> This message is a bit confusing as the number shown here (600) is in fact an
> hexa number: 0x600 = 1536
> 
> Without any explicit "0x" prefix, this message is read like the MFS is set to 600
> bytes.
> 
> MFS, as per MTUs, are usually expressed in decimal base.
> 
> This commit reports both current and default MFS values in decimal so it's less
> confusing for end-users.
> 
> A typical warning message looks like the following :
> 
> 	MFS for port 1 (1536) has been set below the default (9728)
> 
> Signed-off-by: Erwan Velu <e.velu@...teo.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Tested-by: Tony Brelinski <tony.brelinski@...el.com>