netdev - Re: [PATCH net] bridge/br_netlink.c: no need to return void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 19 Apr 2024 12:25:30 +0300
From: Nikolay Aleksandrov <razor@...ckwall.org>
To: Hangbin Liu <liuhangbin@...il.com>, netdev@...r.kernel.org
Cc: Roopa Prabhu <roopa@...dia.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Horatiu Vultur <horatiu.vultur@...rochip.com>,
 Henrik Bjoernlund <henrik.bjoernlund@...rochip.com>, bridge@...ts.linux.dev
Subject: Re: [PATCH net] bridge/br_netlink.c: no need to return void function

On 4/19/24 11:02, Hangbin Liu wrote:
> br_info_notify is a void function. There is no need to return.
> 
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> ---
>   net/bridge/br_netlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 2cf4fc756263..f17dbac7d828 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -667,7 +667,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
>   {
>   	u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
>   
> -	return br_info_notify(event, br, port, filter);
> +	br_info_notify(event, br, port, filter);
>   }
>   
>   /*

Acked-by: Nikolay Aleksandrov <razor@...ckwall.org>